Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(xrk): add new env named Flozen Lake and DQN algorithm. #781

Merged
merged 12 commits into from
Mar 13, 2024
Merged

feature(xrk): add new env named Flozen Lake and DQN algorithm. #781

merged 12 commits into from
Mar 13, 2024

Conversation

rongkunxue
Copy link
Contributor

Description

Add adaptation to gymnasium environment and give examples based on DQN algorithm

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@codecov Codecov
Copy link

codecov bot commented Mar 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.89%. Comparing base (e28438c) to head (d41ece2).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #781      +/-   ##
==========================================
+ Coverage   75.87%   75.89%   +0.02%     
==========================================
  Files         679      681       +2     
  Lines       55249    55287      +38     
==========================================
+ Hits        41920    41962      +42     
+ Misses      13329    13325       -4
Flag Coverage Δ
unittests 75.89% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaParaZz1 PaParaZz1 added the env Questions about RL environment label Mar 13, 2024
PaParaZz1
PaParaZz1 approved these changes Mar 13, 2024
View reviewed changes
ding/example/dqn_frozen_lake.py Outdated Show resolved Hide resolved
dizoo/frozen_lake/config/frozen_lake_dqn_config.py Outdated Show resolved Hide resolved
dizoo/frozen_lake/envs/frozen_lake_env.py Outdated Show resolved Hide resolved
@PaParaZz1 PaParaZz1 merged commit aeb4c9c into opendilab:main Mar 13, 2024
20 checks passed
@PaParaZz1 PaParaZz1 mentioned this pull request Mar 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaParaZz1 PaParaZz1 PaParaZz1 approved these changes

Assignees
No one assigned
Labels
env Questions about RL environment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rongkunxue @PaParaZz1